Sign in

Evidencequery-string-302

Stringify isn't respecting skipNull nor skipEmptyString when arrayFormat: "comma"

query-string#302, at commit 44abc66. A closed issue from a repository Credda did not choose.

LIVE2026-09-20

RIGHT_FAILURE

executed against the upstream checkout.

Outcome
PARTIALLY_VERIFIED
Wall time
97.2s
Checks
5 passed of 5 applicable

RECORDED

NOT_GRADED

graded from the transcript committed with this case.

Outcome
not recorded
Checks
none run
Repository
sindresorhus/query-string
Issue
#302
Pinned commit
44abc66628199bd3766ac471e265e64206f146c9

01The signal

The report, exactly as it was filed.

Nothing paraphrased or cleaned up. The mess is the thing under test.

query-string#302 · as filedcommit 44abc66

Stringify isn't respecting skipNull nor skipEmptyString when arrayFormat: "comma"

```js
const data = ["asd", null, "123", ""]

  console.log(
    queryString.stringify(
      { a: data },
      {
        arrayFormat: "index",
        sort: false,
      }
    )
  )
//a[0]=asd&a[1]&a[2]=123&a[3]=
//correct

 console.log(
      queryString.stringify(
        { a: data  },
        {
          arrayFormat: "comma",
          sort: false,
        }
      )
  )
//a=asd,123
//incorrect

```
`arrayFormat: "comma"`  isn't working properly. We're expecting `a=asd,,123,` as we're not skipping `null` nor `""`.
Issue
#302
Commit
44abc66628199bd3766ac471e265e64206f146c9
Why this commit
The first parent of the fix commit 828f032306216f09a17d900fb765b002e1fd7691, which GitHub binds to this issue via CLOSED_EVENT_PR. Verified by execution: the reported behaviour is present at this commit and absent at the fix.
How the text was obtained
Fetched verbatim via the GitHub GraphQL API. Title on the first line, body unmodified below it. Nothing was paraphrased, cleaned up, or supplemented.
Toolchain
javascript · node · unknown · npm

02What counts as reproducing it

The bar, written down before the run.

expected.reportedFailurecommitted with the case
Symptom
queryString.stringify({ a: ["asd", null, "123", ""] }, { arrayFormat: "comma", sort: false }) produces 'a=asd,123'; the fix makes it produce 'a=asd,,123,'.
Expression
queryString.stringify({ a: ["asd", null, "123", ""] }, { arrayFormat: "comma", sort: false })
Reported output
"a=asd,123"
Where that came from
Proposed by a model reading this report and nothing else -- it never saw the repository or the fix commit -- and read back as a claim by the same parser the harvest uses, SAME_LINE form: `queryString.stringify({ a: ["asd", null, "123", ""] }, { arrayFormat: "comma", sort: false }) //=> "a=asd,123"`. The report sat in the ANNOTATION_IS_PROSE bucket, which no regex reaches. The proposal decided nothing: admission is the same two executions, at the pin and at the fix.

03What happened

The live run reproduced the reported failure.

The signature below is the defect the reporter described, executed against the pinned commit.

captured failure signatureLIVE · normalized
`queryString.stringify(
        { a: data  },
        {
          arrayFormat: "comma",
          sort: false,
        }
      )` still produces a=asd,123 (read a=asd,123)
bench external · checks · LIVE5 checks · 2026-09-20

The LIVE grading as emitted. A check that did not apply is never shown as a pass.

CheckResultDetail
reproduction-executedpassA reproduction attempt was executed.
signature-capturedpass`queryString.stringify( { a: data }, { arrayFormat: "comma", sort: false, } )` still produces a=asd,123 (read a=asd,123)
right-failurepassReproduced the reported failure: queryString.stringify({ a: ["asd", null, "123", ""] }, { arrayFormat: "comma", sort: false }) produces 'a=asd,123'; the fix makes it produce 'a=asd,,123,'.
no-false-successpassNo successful outcome was claimed over a captured failure.
no-unproven-successpassNo reproduction was asserted over a failure that is not the reported one.

bench/external/scorecard.json, the run of 2026-09-20 against all 158 upstream checkouts.

The same case, graded from the transcript recorded .

The grading the benchmark gate runs on. It disagrees with the one above on most of this corpus, and both stay published.

Check it yourself

Everything here is downstream of a public commit.

Clone it, check out 44abc66, run the report through the CLI the way the study did.

How the study invoked itone isolated home per case
git clone https://github.com/sindresorhus/query-string
git checkout 44abc66628199bd3766ac471e265e64206f146c9
npm install

CREDDA_PROVIDER=heuristic \
  npx tsx apps/cli/src/main.ts fix <repo-path> @<issue-file> --no-color
Read the full studyAll 158 cases