Sign in

Evidencequery-string-346

why query-string encode the fragmentIdentifier?

query-string#346, at commit 5beef41. A closed issue from a repository Credda did not choose.

LIVE2026-09-20

RIGHT_FAILURE

executed against the upstream checkout.

Outcome
REPRODUCED_NOT_DIAGNOSED
Wall time
78.1s
Checks
5 passed of 5 applicable

RECORDED

NOT_GRADED

graded from the transcript committed with this case.

Outcome
not recorded
Checks
none run
Repository
sindresorhus/query-string
Issue
#346
Pinned commit
5beef41d37f18916dc15bded8fac803a33153aa2

01The signal

The report, exactly as it was filed.

Nothing paraphrased or cleaned up. The mess is the thing under test.

query-string#346 · as filedcommit 5beef41

why query-string encode the fragmentIdentifier?

```js
queryString.stringifyUrl({
	url: 'https://foo.bar',
	query: {
		top: 'foo'
	},
	fragmentIdentifier: '/bar/hello'
});
// => 'https://foo.bar?top=foo#%2Fbar%2Fhello'
```

if set `{ encode: false }`, the other query also won't be encoded
Issue
#346
Commit
5beef41d37f18916dc15bded8fac803a33153aa2
Why this commit
The first parent of the fix commit 16a7b8f37f8b88f1785b68efca57e55ae96904e2, which GitHub binds to this issue via CLOSED_EVENT_PR. Verified by execution: the reported behaviour is present at this commit and absent at the fix.
How the text was obtained
Fetched verbatim via the GitHub GraphQL API. Title on the first line, body unmodified below it. Nothing was paraphrased, cleaned up, or supplemented.
Toolchain
javascript · node · unknown · npm

02What counts as reproducing it

The bar, written down before the run.

expected.reportedFailurecommitted with the case
Symptom
queryString.stringifyUrl({ url: 'https://foo.bar', query: { top: 'foo' }, fragmentIdentifier: '/bar/hello' }) produces 'https://foo.bar?top=foo#%2Fbar%2Fhello'; the fix makes it produce 'https://foo.bar?top=foo#/bar/hello'.
Expression
queryString.stringifyUrl({ url: 'https://foo.bar', query: { top: 'foo' }, fragmentIdentifier: '/bar/hello' })
Reported output
'https://foo.bar?top=foo#%2Fbar%2Fhello'
Where that came from
Read mechanically from the report's fenced code, NEXT_LINE form: `queryString.stringifyUrl({ url: 'https://foo.bar', query: { top: 'foo' }, fragmentIdentifier: '/bar/hello' }); // => 'https://foo.bar?top=foo#%2Fbar%2Fhello'`.

03What happened

The live run reproduced the reported failure.

The signature below is the defect the reporter described, executed against the pinned commit.

captured failure signatureLIVE · normalized
`queryString.stringifyUrl({
url: 'https://foo.bar',
query: {
top: 'foo'
},
fragmentIdentifier: '/bar/hello'
})` still produces 'https://foo.bar?top=foo#%2Fbar%2Fhello' (read https://foo.bar?top=foo#%2Fbar%2Fhello)
bench external · checks · LIVE5 checks · 2026-09-20

The LIVE grading as emitted. A check that did not apply is never shown as a pass.

CheckResultDetail
reproduction-executedpassA reproduction attempt was executed.
signature-capturedpass`queryString.stringifyUrl({ url: 'https://foo.bar', query: { top: 'foo' }, fragmentIdentifier: '/bar/hello' })` still produces 'https://foo.bar?top=foo#%2Fbar%2Fhello' (read https://foo.bar?top=foo#%2Fbar%2Fhello)
right-failurepassReproduced the reported failure: queryString.stringifyUrl({ url: 'https://foo.bar', query: { top: 'foo' }, fragmentIdentifier: '/bar/hello' }) produces 'https://foo.bar?top=foo#%2Fbar%2Fhello'; the fix makes it produce 'https://foo.bar?top=foo#/bar/hello'.
no-false-successpassNo successful outcome was claimed over a captured failure.
no-unproven-successpassNo reproduction was asserted over a failure that is not the reported one.

bench/external/scorecard.json, the run of 2026-09-20 against all 158 upstream checkouts.

The same case, graded from the transcript recorded .

The grading the benchmark gate runs on. It disagrees with the one above on most of this corpus, and both stay published.

Check it yourself

Everything here is downstream of a public commit.

Clone it, check out 5beef41, run the report through the CLI the way the study did.

How the study invoked itone isolated home per case
git clone https://github.com/sindresorhus/query-string
git checkout 5beef41d37f18916dc15bded8fac803a33153aa2
npm install

CREDDA_PROVIDER=heuristic \
  npx tsx apps/cli/src/main.ts fix <repo-path> @<issue-file> --no-color
Read the full studyAll 158 cases